🚧 add secret keys (iss. #523) #527
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsloan
added
the
config change
|
The change this referenced was reverted back in a78f282 to get the release out. It should be added back in as a separate PR one one that's put in along with this one for a future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #523.
Adds a key for a new secret,
ONE_TRUST_SCRIPT_DOMAIN. This new key causes Kustomize to expect a file with that name to be present and contain the key's value. That file should be included inbase.zip, which is generated from the contents of the Dropboxbasefolder.Also update
service/README.mdwith details about where the key values are kept and how to update them.